Skip to content

fix!: Remove unused PVCs which caused problems #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbernauer merged 6 commits into from
Jul 7, 2025
Merged

fix!: Remove unused PVCs which caused problems #769

sbernauer merged 6 commits into from
Jul 7, 2025

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 3, 2025

Description

Fixes #768

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Jul 3, 2025
Maleware
Maleware previously approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@Maleware Maleware left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM up to very minor comments.

@sbernauer
Copy link
Member Author

sbernauer commented Jul 3, 2025

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/38/

@sbernauer sbernauer requested a review from Maleware July 3, 2025 09:56
Maleware
Maleware previously approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, appreciated! LGTM

@sbernauer
Copy link
Member Author

sbernauer commented Jul 3, 2025 •
edited
Loading

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/39/
=> Passed ✔️

Maleware
Maleware approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@sbernauer sbernauer added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 163dc7b Jul 7, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/remove-pvcs branch July 7, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Maleware Maleware Maleware approved these changes

Assignees

@sbernauer sbernauer

Labels

type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pod crashes can result in broken TrinoCluster

3 participants

@sbernauer @Maleware